Add distinct method to FakeQuerySet #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasman
requested changes
Feb 22, 2024
modelcluster/queryset.py
Outdated
|
|
||
| def distinct(self, *fields): | ||
| if fields and connection.vendor != 'postgresql': | ||
| raise NotSupportedError("DISTINCT ON fields is not supported by this database backend") |
There was a problem hiding this comment.
Is this needed, given that we're bypassing the database here? I guess you're trying to keep FakeQuerySet as close as possible to the real database behaviour, but I think it's fine for FakeQuerySet to have extra functionality that the database doesn't support.
modelcluster/queryset.py
Outdated
| fields = [field.name for field in self.model._meta.fields if not field.primary_key] | ||
| seen_keys = set() | ||
| for result in self.results: | ||
| key = '$$$'.join([str(extract_field_value(result, field)) for field in fields]) |
There was a problem hiding this comment.
I suggest using a tuple here - unlike lists, they're valid to use as keys within a set:
Suggested change
| key = '$$$'.join([str(extract_field_value(result, field)) for field in fields]) | |
| key = tuple(str(extract_field_value(result, field)) for field in fields) |
gasman
approved these changes
Feb 23, 2024
gasman
pushed a commit
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
This PR adds the
distinctmethod to theFakeQuerySetclass. It mimics the behavior of django'sdistinctmethod - calls todistinctwith a list of field names, are only allowed if the db connection vendor is postgresql.